Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facet_search API functionality #512

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

hmacr
Copy link
Contributor

@hmacr hmacr commented Sep 5, 2023

Pull Request

Related issue

Fixes #503

What does this PR do?

  • Add functionality to use the facet-search API
  • Add code samples for the new method

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@hmacr
Copy link
Contributor Author

hmacr commented Sep 5, 2023

@Kerollmops Could you please take a look? Thanks!

Kerollmops
Kerollmops previously approved these changes Sep 12, 2023
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful to me 🤩 Thank you very much!
I'll let @meilisearch/integration-team merge this PR!

@curquiza
Copy link
Member

Hello @hmacr

thanks a lot for your multiple PRs

Can you rebase the branch? there are git conflicts currently

curquiza
curquiza previously approved these changes Apr 15, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Apr 15, 2024
512: Add facet_search API functionality r=curquiza a=hmacr

# Pull Request

## Related issue
Fixes #503 

## What does this PR do?
- Add functionality to use the facet-search API
- Add code samples for the new method

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: hmacr <[email protected]>
Co-authored-by: Clémentine U. - curqui <[email protected]>
Copy link
Contributor

meili-bors bot commented Apr 15, 2024

Build failed:

@curquiza
Copy link
Member

@hmacr if you are still around, can you update the tests? 🙏
sorry for the huge delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Search in facet values facetSearch
3 participants