Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send documents as jsonlines #265

Open
irevoire opened this issue Apr 19, 2022 · 3 comments
Open

Send documents as jsonlines #265

irevoire opened this issue Apr 19, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@irevoire
Copy link
Member

Description
All the functions that create or update documents should send jsonlines instead of a JSON array.

Why
That's faster to process by meilisearch and consumes less memory.

How
Currently, the issue is that when we send a POST or PUT request in the SDK, it's automatically flagged as JSON.
We need to update our internal to support JSON for the settings and jsonlines for the documents.

@irevoire irevoire added enhancement New feature or request good first issue Good for newcomers labels Apr 19, 2022
@matthias-wright
Copy link

I would like to work on this, is this issue still current?
Can the meilisearch server already handle requests that send jsonlines?

@irevoire
Copy link
Member Author

Hey @matthias-wright, yes thanks for your interest, this hasn't been implemented.
Meilisearch can handle jsonlines IF you set the good content-type and only on the POST and PUT route 👍

@postmeback
Copy link
Contributor

If #417 was able to fix this, then please close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants