Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3] Sort facets value by alphanumerical or count order #829

Closed
1 of 3 tasks
brunoocasali opened this issue Aug 8, 2023 · 3 comments · Fixed by #848
Closed
1 of 3 tasks

[v1.3] Sort facets value by alphanumerical or count order #829

brunoocasali opened this issue Aug 8, 2023 · 3 comments · Fixed by #848
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Aug 8, 2023

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, please add any clarification and instructions about this issue.

Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.

Related to meilisearch/integration-guides#280


This issue is divided into two sections, first, you need to make the implementation, and second, you must update the code-samples (no one likes outdated docs, right?).

New implementation

Related to:

Adds the ability to sort facets by their value which could be by using alpha or count.

Ensure the SDKs can handle the new index faceting configuration attribute sortFacetValuesBy. This enum could only take count or alpha.

The faceting configuration now have two attributes:

maxValuesPerFacet: integer
sortFacetValuesBy: object 
  index_name: alpha|count
  *: alpha|count // when should be applied to all indexes

Code samples

Inside of this file: .code-samples.meilisearch.yml:

  1. Create a new entry with this key facet_search_2 containing a call to the updateFaceting settings method.
    With this value: "sortFacetValuesBy":{"genres": "count"}

Use this as a reference if the previous description was not helpful:

facet_search_2: |-
  PATCH 'http://localhost:7700/indexes/books/settings/faceting' 
  with data: {
    "sortFacetValuesBy": {
      "genres": "count"
    }
  }
  1. Update getting_started_faceting key to contain the new behavior sortFacetValuesBy
getting_started_faceting: |-
  PATCH 'http://localhost:7700/indexes/movies/settings/faceting' 
  with data: {
    "maxValuesPerFacet": 2,
    "sortFacetValuesBy": {
      "*": "count"
    }
  }
  1. Update update_faceting_settings_1 key to contain the new behavior sortFacetValuesBy
update_faceting_settings_1: |-
  PATCH 'http://localhost:7700/indexes/books/settings/faceting' 
  with data: {
    "maxValuesPerFacet": 2,
    "sortFacetValuesBy": {
      "*": "alpha",
      "genres": "count"
    }
  }

TODO:

  • Add the ability receive a new param in the updateFaceting settings method called sortFacetValuesBy.
  • Update the code-samples accordingly
  • Add integration tests
@brunoocasali brunoocasali added good first issue Good for newcomers enhancement New feature or request labels Aug 8, 2023
@curquiza
Copy link
Member

curquiza commented Sep 20, 2023

@brunoocasali @sanders41
Let me know if I'm wrong, but the SDK is already compatible because not strongly typed and thanks to the update_faceting_settings method

def update_faceting_settings(self, body: Union[Dict[str, Any], None]) -> TaskInfo:

We only need to update the code samples right?

@sanders41
Copy link
Collaborator

Updating the setting will work, but the Facet model needs to be updated to include the new value. Right now get_facetting_settings won't error, but it also won't contain the sort settings.

class Faceting(CamelBase):
max_values_per_facet: int

@curquiza
Copy link
Member

I updated code samples in this PR: #847

@meili-bors meili-bors bot closed this as completed in d31673b Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants