Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full customisation of probes #233

Open
dtomlinson91 opened this issue Jun 10, 2024 · 1 comment
Open

Allow full customisation of probes #233

dtomlinson91 opened this issue Jun 10, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dtomlinson91
Copy link

dtomlinson91 commented Jun 10, 2024

Description
When using the chart the K8s probes should be fully configurable. #29 did some work adding InitialDelaySeconds and periodSeconds, but I can't think of a reason why all probe options should not be configurable by the user.

The chart would be better served by passing any valid probe object instead of a select few options, but at the very least timeoutSeconds, successThreshold and failureThreshold should be configurable for the liveness & readiness probes if passing a probe object goes against the design of the chart.

Basic example
When under heavy load in our environment it can take more than 1s for the health check to complete. I should be able to specify timeoutSeconds for the liveness & readiness probe to something less agressive than 1s.

As it stands I've had to fork the chart and add this in to use the chart in our environment.

Other
This should be fairly straight forward to implement and I'm happy to raise the PR if needed.

@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Jul 10, 2024
@curquiza
Copy link
Member

Hello @dtomlinson91

Thanks for the suggestion
Any PR are welcome, thank you very much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants