Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MeilisearchException as RuntimeException #677

Closed
junghoon-vans opened this issue Oct 28, 2023 · 0 comments · Fixed by #683
Closed

Make MeilisearchException as RuntimeException #677

junghoon-vans opened this issue Oct 28, 2023 · 0 comments · Fixed by #683
Labels
enhancement New feature or request

Comments

@junghoon-vans
Copy link
Contributor

Description

Currently, all exceptions thrown by the client inherit from the MeilisearchException.class.
However, MeilisearchException is a checked exception, so users who use it must handle the exception.
but enforcing this behavior is not modern.

Basic example

My suggestion is to change the MeilisearchException to a RuntimeException.
Users can only handle the exception if they need to.

Other

As far as I know, almost all datastore clients are designed to throw RuntimeException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants