Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to a fixed HTTP client library OkHttp #419

Closed
alallema opened this issue Aug 2, 2022 · 1 comment · Fixed by #449
Closed

Switch to a fixed HTTP client library OkHttp #419

alallema opened this issue Aug 2, 2022 · 1 comment · Fixed by #449
Assignees
@alallema
Labels
breaking-change The related changes are breaking for the users

Comments

@alallema
Copy link
Contributor

alallema commented Aug 2, 2022

Description
Following this issue #334 and the fact that the PATCH method is now needed in multiple methods since the v0.28.0 of Meilisearch.

Expectations
The need to allow the PATCH method and to keep the Java 8 compatibility pushed us to choose as a solution to use a single HTTP library which in addition to meeting the needs would reduce the dependencies.
OkHttp has the advantages we were looking for it is a very used library that supports PATCH.

What to do?

  • Remove all Java HTTP Client to only keep OkHttp
  • Rewrite the Meilisearch HTTP client to simplify it
@alallema alallema mentioned this issue Aug 2, 2022
Closed
@alallema alallema added the breaking-change The related changes are breaking for the users label Aug 2, 2022
@alallema alallema self-assigned this Aug 2, 2022
@alallema alallema mentioned this issue Aug 4, 2022
Merged
@alallema alallema linked a pull request Oct 24, 2022 that will close this issue
Use OkHttpClient by default and remove the others #449
Merged
@alallema
Copy link
Contributor Author

Clsed by #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alallema alallema

Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use OkHttpClient by default and remove the others meilisearch/meilisearch-java
1 participant
@alallema