Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new code-samples requested by the Meilisearch v0.29 release #210

Closed
2 tasks
brunoocasali opened this issue Oct 18, 2022 · 0 comments · Fixed by #215
Closed
2 tasks

Add new code-samples requested by the Meilisearch v0.29 release #210

brunoocasali opened this issue Oct 18, 2022 · 0 comments · Fixed by #215
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Oct 18, 2022

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, please add any clarification and instructions about this issue.

Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.

Related to meilisearch/integration-guides#213


⚠️⚠️⚠️ This SDK does not have the matchingStrategy yet. To close this issue #207 should be done first.

Add the new code samples into the file .code-samples.meilisearch.yml:

TODO:

  • Add search_parameter_guide_matching_strategy_1
    • Search for big fat liar with "matchingStrategy": "last" in a movies index.
  • Add search_parameter_guide_matching_strategy_2
    • Search for big fat liar with "matchingStrategy": "all" in a movies index.

For example, in Javascript, the code-samples required to fix the issue are:

client.index('movies').search('big fat liar', { matchingStrategy: 'last' }) and also
client.index('movies').search('big fat liar', { matchingStrategy: 'all' })

so the final version inside of the samples should be:

search_parameter_guide_matching_strategy_1: |-
  client.index('movies').search('big fat liar', { matchingStrategy: 'last' })
search_parameter_guide_matching_strategy_2: |-
  client.index('movies').search('big fat liar', { matchingStrategy: 'all' })
@brunoocasali brunoocasali added good first issue Good for newcomers documentation Improvements or additions to documentation hacktoberfest labels Oct 18, 2022
@bors bors bot closed this as completed in #215 Nov 1, 2022
@bors bors bot closed this as completed in c3e2bbc Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant