Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling during the setup with npx #57

Open
brunoocasali opened this issue Mar 29, 2022 · 5 comments
Open

Improve error handling during the setup with npx #57

brunoocasali opened this issue Mar 29, 2022 · 5 comments

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Mar 29, 2022

image

What about WARNING: Warning, FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail

image

@alallema
Copy link
Contributor

What about WARNING: Warning, FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail

FIREBASE_CONFIG and GCLOUD_PROJECT are environment variables on the Firebase Functions servers. The reason they are not defined is that we are running this code in a standard node environment. This is the same error as in this issue: #17 I'm not sure there is a way to avoid it.

@brunoocasali
Copy link
Member Author

Oh, sorry, but I was not clear!

I meant to parse the error message before sending it to the user, not the message itself. Currently, we are just forwarding to the user the JSON we received from the server. I would like to see better handling in this case, maybe just printing the message respecting the line-breaks and paragraphs?

@alallema
Copy link
Contributor

No, it was clear, I just added this explanation to clarify the firebase variables in case.

@bidoubiwa
Copy link
Contributor

What is the state of this issue?

@alallema
Copy link
Contributor

What do you mean? It is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants