-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase transfer function is numerically small #151
Comments
My experience with Tikhonov-regularized least squares is that this is expected behavior. Increasing the regularization parameter penalizes large solutions, so it makes sense that your solutions get smaller as you increase the regularization parameter.
I'm not sure if this will give you the behavior you're looking for. If you 100x H, then your estimate for the phase will need to go down by 100x to match the data, and I expect that your choice of regularization parameter will need to go up by ~100x. (Please prove me wrong!) I'm guessing that the desired behavior is regularization-parameter independent reconstructions. If so, we may need to move beyond Tikhonov-regularized least squares with this property specifically in mind. |
Now that I think of it in this way, this behavior is indeed expected! My initial observation with the reconstruction is that with 100x regularization, the image doesn't change significantly other than a 0.01 scaling factor (but all quite usable). So I was suspecting that some numerical issue obscured the smoothing effect. |
However I'm still puzzled by how the same observation can be explained by 100x different phase objects (in radians) where the structure remains almost the same. |
We have been observing inconsistent dynamic range issues with phase reconstructions across different datasets. When I try sweeping the Tikhonov regularization strength, the same FOV would also have different dynamic ranges:
It seems like the product of the regularization parameter and the width of the histogram stays the same (inverse relation). When inspecting the transfer function, the numerical values appear to be small:
Looking at how the inverse was applied, it seems like the output would be dominated by the regularization parameter we typically use:
waveorder/waveorder/util.py
Lines 972 to 978 in 366ef1b
Here if
H_eff_abs_square
is much smaller thanreg_coeff
, the output will be close to being divided by thereg_coeff
alone, resulting in the inverse relation between regularization strength and the dynamic range of the reconstructed image.@mattersoflight suggests that we rescale$H_{eff}$ to $[0, 1]$ , so that $H_{eff} \gg \rho$ .
The config I used to generate the transfer function:
Dataset:
/hpc/projects/comp.micro/mantis/2023_08_18_A549_DRAQ5/0-zarr/a549_draq5_1/a549_draq5_labelfree_1.zarr/0/0/0
The text was updated successfully, but these errors were encountered: