-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate fluorescence reconstructions to torch
and model
-based structure
#122
Comments
@talonchandler Here is my reading of inputs and outputs, and suggestions for naming conventions:
We should also add The most basic (geometric) model for fluorescence anisotropy |
Yes, |
Great, I like these suggestions a lot.
|
The highest-priority fluorescence reconstruction I'm collecting the remaining migrations into a list here:
|
I'm planning to move the fluorescence reconstructions to
torch
and to the newmodel
-based structure.waveorder_reconstructor/fluorescence_microscopy
class will eventually be deprecatedfluorescence_microscopy
class supports2D
,3D
, andfluorescence anisotropy
reconstructions. Following our<sample_type>_<sample_thickness>_<data_type>
model-name schema, I will suggest moving+renaming these reconstructions to:2D
->isotropic_fluorescent_thin_3d
3D
->isotropic_fluorescent_thick_3d
fluorescence anisotropy
->inplane_anisotropic_fluorescent_thin_pol3d
@mattersoflight naming discussion is welcome.
@mattersoflight @edyoshikun if our immediate needs require just the
isotropic_fluorescent_thick_3d
, then I will prioritize that model.The text was updated successfully, but these errors were encountered: