-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ideas for refactoring: image_parser module is too large #29
Comments
I suggest creating one PR with refactor to which multiple individuals contribute and initiate one or two PRs. Our goal should be to describe dataflow with names of the modules/functions. For example, Load images and metadata, write output: io.load_scienion(path, metadata) Image->OD per well: analyze.segment_well debug plots: OD->calls across wells: The last module (measure ) needs to be defined. |
One difficulty with this approach is that there can not be any permission, PR, or other check that someone pushes changes we all agree upon. Contributors to this branch will simply "push to remote". And all other contributors will have to frequently "pull from origin" and resolve conflicts to make sure we are synched with new pushes. It is possible to do PR to this branch. I think we each can have a repo fork and submit a PR across forks/branches. |
The extract.image_parser module has become a catch-all of functions. Many of these can be moved out.
I'll start by doing the following across two PRs:
The text was updated successfully, but these errors were encountered: