Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for multiple training tasks #127

Closed
mattersoflight opened this issue Aug 8, 2024 · 4 comments · Fixed by #153
Closed

CLI for multiple training tasks #127

mattersoflight opened this issue Aug 8, 2024 · 4 comments · Fixed by #153
Assignees
Labels
breaking Breaking changes representation Representation learning (SSL) translation Image translation (VS)
Milestone

Comments

@mattersoflight
Copy link
Member

As part of #126, @ziw-liu suggested:

For the future iteration (v0.3?) it might make sense to replace the manual CLI entry point (viscy [command]) with python's built-in (python -m viscy.cli.module [command]) to make supporting multiple learning tasks easier.

This makes a lot of sense and I'd vote to make this change sooner to clarify that the repo does implement multiple learning tasks. It is easy to change our virtual training scripts that launch training from viscy [command] -> python -m viscy.cli.module [command]. Are there other factors for which we should wait to refactor CLI?

@ziw-liu @edyoshikun

@ziw-liu
Copy link
Collaborator

ziw-liu commented Aug 8, 2024

I'd do it after v0.2.0 is released (i.e. after #114) so that the v0.1.0 API reported in various places is kept in the release.

@edyoshikun
Copy link
Contributor

I am having trouble seeing what is the added benefit of using python -m viscy.cli.module [command]. What is this enabling?
Also, #114 does not rely on the CLI so you could change it now. I would prefer if you make the changes now and we update the wiki to the latest method of calling the training/prediction than having to change this twice. The instructions will be on the wiki .

@edyoshikun
Copy link
Contributor

I merged #114. @ziw-liu feel free to make the changes

@mattersoflight
Copy link
Member Author

@ziw-liu The change in CLI and the refactor of modules that implement multiple learning tasks can be done in a single PR.

@ziw-liu ziw-liu added this to the v0.3.0 milestone Sep 16, 2024
@ziw-liu ziw-liu added breaking Breaking changes translation Image translation (VS) representation Representation learning (SSL) labels Sep 16, 2024
@ziw-liu ziw-liu linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes representation Representation learning (SSL) translation Image translation (VS)
Projects
None yet
3 participants