feat: env contains list of strings #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
requested changes
Dec 4, 2021
simon-an
force-pushed
the
parse-environment-list
branch
from
4ec2bd6
to
5357c67
Compare
|
Ups. 😄 Done. |
|
I noticed, that with my first implementation one have to decide what to use. Strings or lists of strings. So i added an option which allows adding the keys of environment variables to be listed for parsing. |
|
Any chance we get this merged? |
matthiasbeyer
approved these changes
Jan 6, 2022
|
@matthiasbeyer Hi, can we merge this now? checks are green and branch is up to date. |
|
Yeah I think so. Please rebase the branch so the merge commits vanish! 👍 |
Signed-off-by: simon-an <[email protected]>
simon-an
force-pushed
the
parse-environment-list
branch
from
9e75d32
to
53322d4
Compare
matthiasbeyer
requested changes
Mar 1, 2022
matthiasbeyer
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: simon-an [email protected]
fixes #117