valid circuit-breaker filter spec by correlation #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this ^^ |
localvar
reviewed
Mar 29, 2022
localvar
reviewed
Mar 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 78.58% 78.51% -0.07%
==========================================
Files 94 94
Lines 10862 10878 +16
==========================================
+ Hits 8536 8541 +5
- Misses 1842 1850 +8
- Partials 484 487 +3
Continue to review full report at Codecov.
|
localvar
approved these changes
Mar 29, 2022
localvar
pushed a commit
that referenced
this pull request
Mar 29, 2022
* valid circuit-breaker filter spec by correlation * fix circuit-breaker filter failure legality validate * fix error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circuit breaker filter should valid spec according to the parameter correlation: using the strategy of failure statistics, it should ensure that the relevant required parameters have been set(failureRateThreshold,failureStatusCodes). At this time, the relevant parameters of the slow call are not required, and vice versa.