Turn profiling on/off runtime #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localvar
reviewed
Mar 16, 2022
xxx7xxxx
reviewed
Mar 16, 2022
|
@samutamm , seems two different changes are in the PR |
Co-authored-by: Yun Long <[email protected]> Co-authored-by: Bomin Zhang <[email protected]>
samutamm
force-pushed
the
toggle-profiling-api-532
branch
from
ff19323
to
e1b1765
Compare
Oups! Now it looks ok again |
localvar
reviewed
Mar 17, 2022
localvar
approved these changes
Mar 18, 2022
suchen-sci
approved these changes
Mar 18, 2022
xxx7xxxx
reviewed
Mar 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #543 +/- ##
==========================================
- Coverage 80.63% 78.65% -1.99%
==========================================
Files 88 94 +6
Lines 10122 10818 +696
==========================================
+ Hits 8162 8509 +347
- Misses 1510 1823 +313
- Partials 450 486 +36
Continue to review full report at Codecov.
|
xxx7xxxx
reviewed
Mar 19, 2022
xxx7xxxx
approved these changes
Mar 21, 2022
localvar
added a commit
that referenced
this pull request
Mar 29, 2022
* profile api status command * start profiling endpoints * stop path * egctl profile client * Apply suggestions from code review Co-authored-by: Yun Long <[email protected]> Co-authored-by: Bomin Zhang <[email protected]> * validate profiling paths and do not modify static options * remove filepath validation and move state to profile/profile.go * error handling * use lock to synchronize concurrent modifications * change cluster level lock to profile level lock Co-authored-by: Yun Long <[email protected]> Co-authored-by: Bomin Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...using admin API.
Close #532