Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #479

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix typo #479

merged 1 commit into from
Jan 25, 2022

Conversation

falconluca
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #479 (5c518d8) into main (3c21251) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   80.29%   80.27%   -0.03%     
==========================================
  Files          83       83              
  Lines        9676     9676              
==========================================
- Hits         7769     7767       -2     
- Misses       1464     1466       +2     
  Partials      443      443
Impacted Files Coverage Δ
pkg/object/autocertmanager/autocertmanager.go 93.65% <100.00%> (ø)
pkg/filter/validator/basicauth.go 78.89% <0.00%> (-1.84%) ⬇️
pkg/object/mqttproxy/client.go 80.54% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c21251...5c518d8. Read the comment docs.

samutamm
samutamm approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@samutamm samutamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaohsiung, LGTM!

@haoel haoel merged commit 16a4439 into easegress-io:main Jan 25, 2022
samutamm pushed a commit to samutamm/easegress that referenced this pull request Jan 27, 2022
@falconluca
fix typo (easegress-io#479)
d84b2e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchen-sci suchen-sci suchen-sci approved these changes

@samutamm samutamm samutamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@falconluca @codecov-commenter @samutamm @suchen-sci @haoel