-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CertExtractor filter #474
Merged
Merged
CertExtractor filter #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #474 +/- ##
==========================================
+ Coverage 80.35% 80.47% +0.12%
==========================================
Files 83 84 +1
Lines 9685 9758 +73
==========================================
+ Hits 7782 7853 +71
- Misses 1461 1463 +2
Partials 442 442
Continue to review full report at Codecov.
|
localvar
reviewed
Jan 27, 2022
samutamm
force-pushed
the
cert-extractor-filter
branch
from
January 27, 2022 06:07
5cb513a
to
b3d6f60
Compare
localvar
reviewed
Jan 28, 2022
localvar
approved these changes
Jan 28, 2022
Co-authored-by: Bomin Zhang <[email protected]>
Co-authored-by: Bomin Zhang <[email protected]>
samutamm
force-pushed
the
cert-extractor-filter
branch
from
February 9, 2022 10:39
3425a79
to
db593d7
Compare
zouyingjie
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #467
CertExtractor filter adds values from certificates Subject or Issuer to headers.
Here's an example config:
that extracts the "CommonName" field's value from the subject of the last certificate. The value is set to "X-AUTH-USER" request header.
Here's an example that sets
CommonName
value for new certificate: https://github.com/haoel/mTLS/blob/main/certs.go#L141References: