Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose max-sync-message-size in options #419

Merged
merged 9 commits into from
Dec 21, 2021

Conversation

samutamm
Copy link
Contributor

Fix #413

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #419 (39d414a) into main (8ac2bab) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   80.46%   80.43%   -0.03%     
==========================================
  Files          62       70       +8     
  Lines        7112     8093     +981     
==========================================
+ Hits         5723     6510     +787     
- Misses       1095     1223     +128     
- Partials      294      360      +66     
Impacted Files Coverage Δ
pkg/cluster/cluster.go 50.68% <100.00%> (-0.94%) ⬇️
pkg/object/mqttproxy/storage.go 82.19% <0.00%> (-12.69%) ⬇️
pkg/object/mqttproxy/broker.go 75.00% <0.00%> (-4.69%) ⬇️
pkg/object/mqttproxy/client.go 78.60% <0.00%> (-2.50%) ⬇️
pkg/object/mqttproxy/session.go 82.20% <0.00%> (-0.11%) ⬇️
pkg/object/mqttproxy/spec.go 100.00% <0.00%> (ø)
pkg/util/ratelimiter/ratelimiter.go 100.00% <0.00%> (ø)
pkg/object/pipeline/mock.go 81.01% <0.00%> (ø)
pkg/object/pipeline/pipeline.go 88.65% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac2bab...39d414a. Read the comment docs.

pkg/option/option.go Outdated Show resolved Hide resolved
@suchen-sci
Copy link
Contributor

If user create yaml file larger than MaxCallSendMsgSize, I think we better log that to help them find problem. One way to do that is in statussynccontroller .go line 217, when err is not nil, except logging the error. We can also check if the length of kvs is exceed MaxCallSendMsgSize . Is this a good idea?

@localvar localvar merged commit 554efe7 into easegress-io:main Dec 21, 2021
@samutamm samutamm deleted the expose-etcd-max-msg-size branch December 21, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceExhausted error when creating many HTTPPipelines and HTTPServer paths
4 participants