Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: global filter #376

Merged
merged 15 commits into from
Nov 26, 2021
Merged

feature: global filter #376

merged 15 commits into from
Nov 26, 2021

Conversation

brzyangg
Copy link
Contributor

Add business controller global filter

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #376 (6b64eb2) into main (9646f79) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   80.57%   80.54%   -0.04%     
==========================================
  Files          57       60       +3     
  Lines        6637     6893     +256     
==========================================
+ Hits         5348     5552     +204     
- Misses       1004     1045      +41     
- Partials      285      296      +11     
Impacted Files Coverage Δ
pkg/object/httppipeline/httppipeline.go 78.78% <66.66%> (-0.60%) ⬇️
pkg/cluster/cluster.go 48.76% <0.00%> (-1.06%) ⬇️
pkg/object/websocketserver/spec.go 100.00% <0.00%> (ø)
pkg/object/websocketserver/proxy.go 77.83% <0.00%> (ø)
pkg/object/websocketserver/websocket.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9646f79...6b64eb2. Read the comment docs.

pkg/object/globalfilter/globalfilter.go Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
@xxx7xxxx
Copy link
Contributor

Integration test failed, please check it.

@brzyangg
Copy link
Contributor Author

This problem has been fixed, mainly because filterIndex uses := assignment

pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
pkg/object/globalfilter/globalfilter.go Outdated Show resolved Hide resolved
@xxx7xxxx xxx7xxxx merged commit 6394a0f into easegress-io:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants