Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test and fix bugs for websocket #379

Merged
merged 13 commits into from
Nov 23, 2021
Merged

add test and fix bugs for websocket #379

merged 13 commits into from
Nov 23, 2021

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Nov 18, 2021

  1. add more test
  2. add mock for supervisor
  3. fix inherit panic (double registry http.DefaultMux by call http.HandleFunc in Init and Inherit).
  4. fix close problem (proxy.server not set)
  5. fix tls not work (use ListenAndServeTLS)
  6. update copyHeader to copy all headers except ones used in gorilla/websocket

@suchen-sci suchen-sci marked this pull request as draft November 18, 2021 06:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #379 (adfa4c7) into main (2988988) will decrease coverage by 0.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   80.48%   80.38%   -0.11%     
==========================================
  Files          57       60       +3     
  Lines        6637     6888     +251     
==========================================
+ Hits         5342     5537     +195     
- Misses       1008     1058      +50     
- Partials      287      293       +6     
Impacted Files Coverage Δ
pkg/object/websocketserver/proxy.go 77.83% <87.50%> (ø)
pkg/object/mqttproxy/session.go 74.39% <0.00%> (-7.93%) ⬇️
pkg/object/websocketserver/spec.go 100.00% <0.00%> (ø)
pkg/object/websocketserver/websocket.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b0e8b...adfa4c7. Read the comment docs.

@suchen-sci suchen-sci marked this pull request as ready for review November 22, 2021 06:26
@suchen-sci suchen-sci changed the title add test for websocket add test and fix bug for websocket Nov 22, 2021
@suchen-sci suchen-sci changed the title add test and fix bug for websocket add test and fix bugs for websocket Nov 22, 2021
pkg/object/websocketserver/proxy.go Outdated Show resolved Hide resolved
pkg/object/websocketserver/proxy.go Outdated Show resolved Hide resolved
pkg/object/websocketserver/proxy.go Outdated Show resolved Hide resolved
pkg/object/websocketserver/proxy.go Outdated Show resolved Hide resolved
pkg/object/websocketserver/proxy.go Outdated Show resolved Hide resolved
@localvar localvar merged commit 0e61435 into easegress-io:main Nov 23, 2021
@suchen-sci suchen-sci deleted the websocket-unit-test branch November 23, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants