Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information for distributed tracing #316

Closed
xxx7xxxx opened this issue Oct 21, 2021 · 2 comments · Fixed by #360
Closed

Add more information for distributed tracing #316

xxx7xxxx opened this issue Oct 21, 2021 · 2 comments · Fixed by #360
Assignees
Labels
enhancement New feature or request

Comments

@xxx7xxxx
Copy link
Contributor

Background

The tracing information only contains http server and pipeline name as different span. It's hard to debug when it comes to more details.

Proposal

  1. Add some standard information such as path, method to tags payload.
  2. Support config to add user-defined tags, e.g:
kind: HTTPServer
name: http-server-example
port: 10080
tracing:
  serviceName: httpServerExmple
  zipkin:
    hostport: 0.0.0.0:10080
    serverURL: http://localhost:9412/api/v2/spans
    sampleRate: 1
    sameSpan: true
    id128Bit: false
    tags:               # +
      MyTagKey: X-Value # +
rules:
  - paths:
    - pathPrefix: /pipeline
      backend: http-pipeline-example
@samutamm samutamm added the enhancement New feature or request label Nov 9, 2021
@samutamm
Copy link
Contributor

samutamm commented Nov 9, 2021

This is a good idea. I agree that http.path and http.method are good standard tags to include by default and the rest can be supported by user defined tags. Opentracing-go span.SetTag can be used to add the tags.

@samutamm
Copy link
Contributor

samutamm commented Nov 9, 2021

I would move the custom tags to same level as zipkin entry, as they are not necessary zipkin specific. Like this:

kind: HTTPServer
name: http-server-example
port: 10080
tracing:
  serviceName: httpServerExample
  tags:                 # +
      MyTagKey: X-Value # +
  zipkin:
    hostport: 0.0.0.0:10080
    serverURL: http://localhost:9412/api/v2/spans
    sampleRate: 1
    sameSpan: true
    id128Bit: false
rules:
  - paths:
    - pathPrefix: /pipeline
      backend: http-pipeline-example

samutamm pushed a commit that referenced this issue Nov 9, 2021
localvar added a commit that referenced this issue Nov 9, 2021
* fix #316; Add more tracing information

* update controller doc and simplify distributed_tracing doc

* Update doc/cookbook/distributed_tracing.md

Co-authored-by: Bomin Zhang <[email protected]>

* go fmt

Co-authored-by: Bomin Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants