Replies: 1 comment
-
That all sounds good to me! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As part of the code base refactoring, here is the idea behind the baseService refactoring.
At the moment, the baseService holds the method to work with transactions and atomic phases as well as some method like buildQuery_, setMetadata_ etc.
All the services that extends the baseService are for now, implementing there own
withTransaction
method which is always the same approach as follow as explain here 👇The refactoring idea is the following:
Creating a new class
TransactionBaseService
that is abstract since there is no reason to instanciate that class as it is and it will holds the defaultwithTransaction
implementation as well as theatomicPhase_
method.The other methods from the baseService are considered as utilities method since they do not depends on the class context. Therefore, they will be move to the utility directory as utility functions.
Here is the related PR and any feedback is welcome.
PS: As part of a bigger refactoring, that class will be part of the core package instead of
medusa-interfaces
@oliverheaps @srindom here is the summary
Beta Was this translation helpful? Give feedback.
All reactions