Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate config from main source code #194

Open
jonathanbataire opened this issue Jul 29, 2024 · 1 comment · May be fixed by #240
Open

separate config from main source code #194

jonathanbataire opened this issue Jul 29, 2024 · 1 comment · May be fixed by #240
Assignees
@jonathanbataire

Comments

@jonathanbataire
Copy link

jonathanbataire commented Jul 29, 2024 •
edited
Loading

Like CHT config needs to be separate from main code (src/config/config-factory.ts) this will make configuration more flexible
config could be read from an external file or a UI component built out to handle this
@jonathanbataire jonathanbataire self-assigned this Jan 14, 2025
@jonathanbataire jonathanbataire linked a pull request Jan 14, 2025 that will close this issue
Open
@kennsippell
Copy link
Member

kennsippell commented Jan 14, 2025 •
edited
Loading

@jonathanbataire Can you explain why you think this is necessary? Why do users want this? It is fine to say "cht-core does this so we have to", but I actually disagree that this is a good user experience.

Should config be provided in the docker container? It feels like actually uploading this through the UI is not very necessary. Are you thinking of this as a feature for developers or as something end users would actually do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanbataire jonathanbataire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes configuration uploadable thru UI medic/cht-user-management
2 participants
@kennsippell @jonathanbataire