Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing purge key from app settings and uploading to server does not disable purging #643

Open
sugat009 opened this issue Nov 12, 2024 · 0 comments
Labels
Type: Bug Fix something that isn't working as intended

Comments

@sugat009
Copy link
Member

Describe the bug
This issue is related to #642. This is mostly related to the upload part. After removing the purge key manually from app_settings.json and uploading it to the server. It doesn't get updated in the settings in the database.

To Reproduce
Steps to reproduce the behavior:

  1. Create a purge.js file and add your purge logic
  2. Run the command cht compile-app-settings upload-app-settings
  3. Purging should be enabled
  4. Manually remove the purge key from the app_settings.json file
  5. Run the command cht upload-app-settings
  6. Check if purging is disabled

Expected behavior
Purging should be disabled if the purge key is removed from the app_settings.json file and uploaded to the server.

Logs
If applicable, include the cht-conf output, server logs, and/or browser logs.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • Instance: Local
  • Client platform: Linux
  • cht-conf version: 4.1.1
  • cht-core version: 4.13

Additional context
A workaround as described in #642 is to make the purging.js file blank and then, compile and upload the settings works but it creates a key in the settings in the database with an empty object which is probably not ideal.

@sugat009 sugat009 added the Type: Bug Fix something that isn't working as intended label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant