Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update nestjs dependencies #5

Open
mojo2012 opened this issue Jul 29, 2021 · 6 comments
Open

Please update nestjs dependencies #5

mojo2012 opened this issue Jul 29, 2021 · 6 comments

Comments

@mojo2012
Copy link

Hi,

this project is awesome. Unfortunately it still depends on @nestjs/common@"^7.5.5. Could you please keep it updated with the newest nestjs releases.

Best regards,
matthias

@mbraz
Copy link

mbraz commented Jun 2, 2022

same need!

@AckerApple
Copy link
Contributor

AckerApple commented Jun 7, 2022

Having same issue. Leaving error details for those searching

I’ll make a PR against this to see if I can help out

npm ERR! While resolving: @medibloc/[email protected]
[32] npm ERR! Found: @nestjs/[email protected]
[33] npm ERR! node_modules/@nestjs/common
[34] npm ERR!   @nestjs/common@"~8.4.4" from the root project

npm ERR! Could not resolve dependency:
[44] npm ERR! peer @nestjs/common@"^7.5.5" from @medibloc/[email protected]

@AckerApple
Copy link
Contributor

I have created #7 to resolve this issue. Looking forward to review

@AckerApple
Copy link
Contributor

AckerApple commented Jun 7, 2022

ALTERNATIVE SOLUTION:

This issue can also be solved by installing another clone of this project that someone else made on npm

npm install nestjs-request-context
  • You will need to find/replace imports of @medibloc/nestjs-request-context with nestjs-request-context
  • You may need to change RequestContext.get() into other notations such as RequestContext.currentContext.req

However eventually overtime that package will have the same issue because it has peerDependencies that require nestjs 8 so if 9 comes out we will hit this same issue again. Here is a link to the peerDependencies that are bad

@AckerApple
Copy link
Contributor

@mojo2012 my changes have been merged. I have requested these changes to be published to npm. You should be able to test the change in v1.0.1

Be well. Close issue when satisfied.

@agborkowski
Copy link

works well with

    "@nestjs/common": "^8.0.0",
    "@nestjs/config": "^2.0.0",
    "@nestjs/core": "^8.0.0",
    "@nestjs/platform-express": "^8.0.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants