Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bounty] automating official brew update #692

Open
louis030195 opened this issue Nov 17, 2024 · 11 comments · Fixed by #709
Open

[bounty] automating official brew update #692

louis030195 opened this issue Nov 17, 2024 · 11 comments · Fixed by #709
Labels

Comments

@louis030195
Copy link
Collaborator

/bounty 80

basically update https://github.com/mediar-ai/screenpipe/blob/main/.github/workflows/release-cli.yml to properly automate official brew too when ran

(if linux is too hard just skip for now, focus on macos)

@Anshgrover23 want to give a shot?

@louis030195 louis030195 added the enhancement New feature or request label Nov 17, 2024
Copy link

linear bot commented Nov 17, 2024

Copy link

algora-pbc bot commented Nov 17, 2024

💎 $80 bounty • Screenpi.pe

Steps to solve:

  1. Start working: Comment /attempt #692 with your implementation plan
  2. Submit work: Create a pull request including /claim #692 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to mediar-ai/screenpipe!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @vishwamartur Nov 19, 2024, 6:11:10 PM WIP
🟢 @krushnarout Nov 20, 2024, 2:55:20 PM #709

@Neptune650
Copy link
Contributor

@louis030195 I can do this - but I need to know what permissions the PAT token in the GitHub CI has.

@vishwamartur
Copy link

vishwamartur commented Nov 19, 2024

/attempt #692

vishwamartur added a commit to vishwamartur/screenpipe that referenced this issue Nov 19, 2024
Related to mediar-ai#692

Automate the official brew update in the `release-cli.yml` workflow for macOS.

* **Formula/screenpipe.rb**
  - Update the `version` field to "0.1.99".
  - Update the `sha256` field for both `x86_64` and `arm64`.
  - Update the `url` field to match the new version.

* **.github/workflows/release-cli.yml**
  - Add a step to update the Homebrew formula after calculating the SHA256.
  - Add a step to create a pull request to update the Homebrew formula.
vishwamartur added a commit to vishwamartur/screenpipe that referenced this issue Nov 19, 2024
Related to mediar-ai#692

Automate the official brew update in the `release-cli.yml` workflow for macOS.

* **Formula/screenpipe.rb**
  - Update the `version` field to "0.1.99".
  - Update the `sha256` field for both `x86_64` and `arm64`.
  - Update the `url` field to match the new version.

* **.github/workflows/release-cli.yml**
  - Add a step to update the Homebrew formula after calculating the SHA256.
  - Add a step to create a pull request to update the Homebrew formula.

Signed-off-by: Vishwanath Martur <[email protected]>
@krushnarout
Copy link
Contributor

krushnarout commented Nov 20, 2024

/attempt #692

Copy link

algora-pbc bot commented Nov 20, 2024

💡 @krushnarout submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Nov 21, 2024

🎉🎈 @krushnarout has been awarded $80! 🎈🎊

@louis030195
Copy link
Collaborator Author

@krushnarout can you re open a PR to actually make this work?

this does not work https://github.com/mediar-ai/screenpipe/actions/runs/11958669798

@louis030195 louis030195 reopened this Nov 21, 2024
@krushnarout
Copy link
Contributor

@krushnarout can you re open a PR to actually make this work?

this does not work https://github.com/mediar-ai/screenpipe/actions/runs/11958669798

Sure, I'll reopen it.

@krushnarout
Copy link
Contributor

krushnarout commented Nov 22, 2024

@louis030195 I found the solution after opening a discussion https://github.com/orgs/Homebrew/discussions/5753. They explained that the duplicate PR https://github.com/mediar-ai/screenpipe/actions/runs/11958669798 happened because someone else also created a PR, so there's not much you can do about that.

They mentioned that the code is correct, but you should remove the entire brew setup. GitHub Actions runners already have Homebrew installed, so there's no need to manually specify the URL or SHA checksum.

https://github.com/orgs/Homebrew/discussions/5753#discussioncomment-11346494

Should I open a new pull request?

@louis030195
Copy link
Collaborator Author

@louis030195 I found the solution after opening a discussion https://github.com/orgs/Homebrew/discussions/5753. They explained that the duplicate PR https://github.com/mediar-ai/screenpipe/actions/runs/11958669798 happened because someone else also created a PR, so there's not much you can do about that.

They mentioned that the code is correct, but you should remove the entire brew setup. GitHub Actions runners already have Homebrew installed, so there's no need to manually specify the URL or SHA checksum.

https://github.com/orgs/Homebrew/discussions/5753#discussioncomment-11346494

Should I open a new pull request?

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants