Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command line option to disable shared folder #66

Closed
wants to merge 1 commit into from
Closed

add command line option to disable shared folder #66

wants to merge 1 commit into from

Conversation

mkinney
Copy link

@mkinney mkinney commented Jan 5, 2020

Resolves #65

Unfortunately, it does not speed up the start.

$ time mech up
Loading metadata for box 'bento/centos-8' (201912.04.0)
Extracting box 'bento/centos-8'...
Added network interface to vmx file
Bringing machine up...
Getting IP address...
Sharing current folder...
VM started on 192.168.2.219

real	0m54.385s
user	0m4.161s
sys	0m0.804s

$ mech destroy -f
Deleting...

$ time mech up --disable-shared-folder
Loading metadata for box 'bento/centos-8' (201912.04.0)
Extracting box 'bento/centos-8'...
Added network interface to vmx file
Bringing machine up...
Getting IP address...
Sharing current folder...
VM started on 192.168.2.219

real	0m54.791s
user	0m4.306s
sys	0m0.827s
$

@ColdHeat
Copy link
Collaborator

ColdHeat commented Feb 4, 2020

I'd like to get a better understanding of #65 before merging this in. I do think this should be --disable-shared-folders though.

@mkinney
Copy link
Author

mkinney commented Feb 4, 2020

Going to close this PR as I have a much larger PR that will encompass this change.

@mkinney mkinney closed this Feb 4, 2020
@mkinney mkinney mentioned this pull request Feb 14, 2020
Open
@mkinney mkinney deleted the disable-shared-folder-option branch February 19, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add the ability to disable shared folders
2 participants
@mkinney @ColdHeat