From f6e05cf2d5bd030ce78f794554d29129b7d6c818 Mon Sep 17 00:00:00 2001 From: Kevin Seymour Date: Wed, 10 May 2023 09:10:46 -0400 Subject: [PATCH] Correctly compare non-object parameters in isConstrainedByInterface --- .../mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java b/src/main/java/com/mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java index a4534d25..a08f3906 100644 --- a/src/main/java/com/mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java +++ b/src/main/java/com/mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java @@ -351,7 +351,7 @@ private boolean isConstrainedByInterface(FQMethod fqMethod) { for (int i = 0; i < infTypes.size(); i++) { String infParmType = infTypes.get(i); String fqParmType = fqTypes.get(i); - if (infParmType.equals(fqParmType)) { + if (!infParmType.equals(fqParmType)) { if (infParmType.charAt(0) != 'L' || fqParmType.charAt(0) != 'L') { matches = false; break;