Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing rootProps to resolveData #711

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support passing rootProps to resolveData #711

wants to merge 2 commits into from

Commits on Nov 21, 2024

  1. Support passing rootProps to resolveData

    haidv committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9579ef9 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. fix: Ensure rootProps are correctly passed during component data reso… 

    …lution

- Updated `resolveAllData` to pass `rootProps` to all components during data resolution.
- Modified `resolveComponentData` to accept and utilize `rootProps` in the resolution process.
- Ensured `rootProps` is correctly passed from `dynamicRoot` and used in all necessary resolver functions.
- Added logging to track `rootProps` values in both editor and render modes to help with debugging.

This ensures consistent handling of `rootProps` in both the Puck editor and render modes, resolving the issue where `rootProps` were missing in render mode.
    haidv committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c7e38a2 View commit details
    Browse the repository at this point in the history