Support passing rootProps to resolveData #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
…lution - Updated `resolveAllData` to pass `rootProps` to all components during data resolution. - Modified `resolveComponentData` to accept and utilize `rootProps` in the resolution process. - Ensured `rootProps` is correctly passed from `dynamicRoot` and used in all necessary resolver functions. - Added logging to track `rootProps` values in both editor and render modes to help with debugging. This ensures consistent handling of `rootProps` in both the Puck editor and render modes, resolving the issue where `rootProps` were missing in render mode.
|
Apologies for delay in reviewing your PRs @haidv1992 - I've clocked them but have some catching up to do. Watch this space! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for passing
rootPropsfromnewData.root.propsintoresolveDatato enable dynamic configuration based on root-level properties.Changes
useResolvedDatato extractrootPropsfromnewData.root.props.resolveComponentDatato accept and passrootPropsintoresolveData.Herocomponent to demonstrate usage ofrootProps.Config.tsxto includerootProps.Testing
rootPropsare correctly passed to components.