Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Deprecated packages #122

Closed
ilanbiala opened this issue Aug 1, 2014 · 4 comments
Closed

Deprecated packages #122

ilanbiala opened this issue Aug 1, 2014 · 4 comments

Comments

@ilanbiala
Copy link
Member

npm WARN deprecated [email protected]: use grunt-ng-annotate instead
npm WARN deprecated [email protected]: use ng-annotate instead

@ilanbiala
Copy link
Member Author

@amoshaviv @roieki Why not just annotate the code ourselves, it takes about 10 seconds and we aren't dependent on anything.

The only change that an annotation makes is:

angular.module('website.about').controller('AboutController', function($scope) {}); to angular.module('website.about').controller('AboutController', ['$scope', function($scope) {}]); by adding an array with the function as the last parameter and strings with the dependencies.

@lirantal
Copy link
Member

@ilanbiala this one is still relevant?

@ilanbiala
Copy link
Member Author

Not sure @roieki can I see what you guys currently have for Gulp?

@rschwabco
Copy link
Member

Going to be released during the weekend (hopefully).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants