-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable OIDC with Synology SSO Server #4544
fix: Enable OIDC with Synology SSO Server #4544
Conversation
+1 |
I think it would be better and more extensible to introduce a new env var |
@JoTec2002 if you could take a look at the feedback from @cmintey we should be able to get this merged! |
@cmintey I completed the changes you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One more small thing to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
Mealie required the
name
claim from an OIDC Provider, but the Synology SSO Server doesn't Provide this claim.After this Pull Request Mealie will no longer required the
name
claim to be present.To not cause any issues or lose any OIDC user information the following logic is used:
If the
name
claim is present it will be used, otherwise the username will be used as name.Which issue(s) this PR fixes:
Fixes #4543