Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] [Task] - Allow Mealie Recipes to be Scraped by Mealie/Others #870

Closed
2 tasks
hay-kot opened this issue Dec 7, 2021 · 3 comments · Fixed by #2539
Closed
2 tasks

[v1.0.0b] [Task] - Allow Mealie Recipes to be Scraped by Mealie/Others #870

hay-kot opened this issue Dec 7, 2021 · 3 comments · Fixed by #2539
Labels
feature task General Task that needs to be completed v1 Version 1 Issue/PR
Milestone

Comments

@hay-kot
Copy link
Collaborator

hay-kot commented Dec 7, 2021

What is the problem this task addresses?

Currently no schema is provided in the Meta Tags according to the schema.org specifications.

Proposed/Possible Solution(s)?

  • Write a server-side javascript function to convert Mealie to Schema.org
  • Publish that (server-side) on the share pages.

SSR is already implemented so all that really should need to be done is to write the converter and add the proper data to the function on the shared page.

@hay-kot hay-kot added task General Task that needs to be completed v1 Version 1 Issue/PR labels Dec 7, 2021
@stale
Copy link

stale bot commented May 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 24, 2022
@hay-kot hay-kot removed the wontfix This will not be worked on label May 24, 2022
@hay-kot hay-kot added this to the v1.0.0 milestone May 31, 2022
@xarantolus
Copy link
Contributor

Hey, I wanted to look into this, but it looks like this has already been implemented? At least the RecipePage uses useMeta and that already contains ld+json data that also shows up in the page.

One thing I'm not sure about is whether this should be available without running JavaScript, e.g. the mealie scraper itself doesn't seem to run JavaScript, which is why it can't find this data. Is there a way to tell Nuxt to include this data in the initial HTML page?

@hay-kot
Copy link
Collaborator Author

hay-kot commented Nov 9, 2022

Is there a way to tell Nuxt to include this data in the initial HTML page?

SSR should be happening in production but not development. It's a limitation of Nuxt/Vite right now. Hopefully this get's resolved in Nuxt v3

Hey, I wanted to look into this, but it looks like this has already been implemented? At least the RecipePage uses useMeta and that already contains ld+json data that also shows up in the page.

As far as I've tested (and remember), it only partially works. I think the main parts are there, but some debugging and troubleshooting needs to happen to get this working 100%. The main issue is that you need to build the docker image to test since that's the only way to support SSR at the moment.

Workflow is Make Changes -> Build Image -> Test Scraper

To test you can use the recipe-scrapers package and write a small python script to hit your local endpoint.


This one's sort of weird to work on so let me know if you need any help or tag me on the discord channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature task General Task that needs to be completed v1 Version 1 Issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants