Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Setting theme primary colour doesn't change theme-color meta #4563

Open
5 of 6 tasks
tecosaur opened this issue Nov 16, 2024 · 1 comment
Open
5 of 6 tasks
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers

Comments

@tecosaur
Copy link

tecosaur commented Nov 16, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

I've recently customised the THEME_DARK_ACCENT and THEME_LIGHT_PRIMARY on my Mealie instance. After figuring out the caching issues, I've noticed that the theme-color meta tag isn't affected by this, leading to what I'd consider a UI bug:

ima_83684e1

On iOS for instance, the orange banner appears as you start scrolling, which is rather jarring difference from the selected primary colour used in the banner.

Steps to Reproduce

  • Customise your mealie colours
  • Observe

Please provide relevant logs

n/a

Mealie Version

v2.2.0

Deployment

Other (please specify below)

Additional Deployment Details

On NixOS

@tecosaur tecosaur added bug Something isn't working triage labels Nov 16, 2024
@Kuchenpirat Kuchenpirat added bug: confirmed good first issue Good for newcomers and removed triage labels Dec 16, 2024
@Kuchenpirat
Copy link
Collaborator

The theme color meta tag is set to primary there here:

theme_color: process.env.THEME_LIGHT_PRIMARY || "#E58325",

But i could reproduce it not having any effect so marking as confirmed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants