Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Offline detection of shopping list is broken #3859

Closed
6 tasks done
MoritzWeber0 opened this issue Jul 6, 2024 · 2 comments · Fixed by #3837
Closed
6 tasks done

[BUG] - Offline detection of shopping list is broken #3859

MoritzWeber0 opened this issue Jul 6, 2024 · 2 comments · Fixed by #3837
Labels
bug: confirmed bug Something isn't working

Comments

@MoritzWeber0
Copy link

MoritzWeber0 commented Jul 6, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When accessing the Shopping list on a Android device (in my case Xiaomi 13t) and then switch to offline mode (turn off Wifi and mobile data), it doesn't recognize it properly. The offline message is only displayed for an short time after a request was initiated. It resets directly to the previous value before the change. I can reproduce it on Firefox and Chrome for Android.

Screen recording:

WhatsApp.Video.2024-07-06.at.12.36.03.mp4

I can not reproduce it when using the desktop version (Linux). If I set the throttling to "Offline", then it all works fine.

Steps to Reproduce

  1. Open the Shopping List
  2. Turn off Wifi and mobile data or turn on flight mode
  3. It's not possible to modify list items as described above.

Please provide relevant logs

Console log: demo.mealie.io-1720262329786.log

Looks like the service worker caches the requests. In offline mode the requests still return 200 OK (from service worker). Screenshot from Network tab:

image

Zipped HAR file (you can extract it and then import the HAR file in the network tab of Chrome):
demo.mealie.io.zip

Might be related to #3842.

Mealie Version

v1.10.2, can also be reproduced with the demo version.

Deployment

Docker (Linux)

Additional Deployment Details

No response

@MoritzWeber0 MoritzWeber0 added bug Something isn't working triage labels Jul 6, 2024
@michael-genson
Copy link
Collaborator

Should be fixed by #3837

@boc-the-git
Copy link
Collaborator

Marking as confirmed, based on Michael's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants