Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] - LDAP server requiring STARTTLS causes error #2185

Closed
5 tasks done
Caligatio opened this issue Feb 26, 2023 · 2 comments · Fixed by #2199
Closed
5 tasks done

[v1.0.0b] - LDAP server requiring STARTTLS causes error #2185

Caligatio opened this issue Feb 26, 2023 · 2 comments · Fixed by #2199

Comments

@Caligatio
Copy link
Contributor

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

What is the issue you are experiencing?

My LDAP server requires STARTTLS which causes Mealie to throw an exception when trying to authenticate any user:

ldap.CONFIDENTIALITY_REQUIRED: {'msgtype': 97, 'msgid': 1, 'result': 13, 'desc': 'Confidentiality required', 'ctrls': [], 'info': 'TLS confidentiality required'}

Quickly looking through the code, I don't see any reference to a .start_tls_s() call by the LDAP client.

Deployment

Docker (Linux)

Deployment Details

No response

@cmintey
Copy link
Contributor

cmintey commented Feb 27, 2023

Hey there. Unfortunately, I don't have STARTTLS enabled with my LDAP setup so I cannot test this fix. Are you able to do some testing locally? I have a working branch if you'd be able to clone and try it out: https://github.com/cmintey/mealie/tree/fix/ldap-starttls

I've added a new LDAP_ENABLE_STARTTLS environment variable that you can set to True and test

@Caligatio
Copy link
Contributor Author

Sorry for the delay @cmintey on testing this.

I can confirm that your branch makes STARTTLS work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants