Fix getBuildFolderPath method for IDE 1.6.12 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, it should be compiled against Arduino |
|
Thanks for letting me know! I will fix travis and merge :) |
|
any update on this...?? |
|
@facchinm Would you mind sharing the fixed Thanks! |
|
Here we go 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Editor Cleanup (arduino/Arduino#4363) was merged, next IDE will "lose" deterministic build directory.
Sketch.getBuildPath()was introduced to get that directory. The code uses the previous fallback mechanism to adapt to any IDE version (tested on 1.6.12 and 1.6.5)Also applies to https://github.com/esp8266/arduino-esp8266fs-plugin