Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Consolidate pre/code/inlineCode #743

Closed
johno opened this issue Aug 21, 2019 · 4 comments
Closed

RFC: Consolidate pre/code/inlineCode #743

johno opened this issue Aug 21, 2019 · 4 comments
Labels
💎 v2 Issues related to v2
Milestone

Comments

@johno
Copy link
Member

johno commented Aug 21, 2019

Having different nodes from remark/rehype is a bit confusing, especially now that one can differentiate by using parentName.

@johno johno added the 💎 v2 Issues related to v2 label Aug 21, 2019
@ehowey
Copy link

ehowey commented Dec 31, 2019

Heads up that when I was running a11y checks on my site I am getting an error requiring tabindex="0" and overflow-y="auto", pops up when the code box is smaller than the viewport and scrolls. Maybe an easy fix to include when making other optimizations.

@ehowey
Copy link

ehowey commented Jan 1, 2020

Now as I think about this more I realize this is actually trickier, because you wouldn't want every code block to be tabbable by default. I was getting the accessibility error on a code block that had a very long line of code and was creating scroll bars on it. I think I can maybe handle this a different way.

@johno johno changed the title Consolidate pre/code/inlineCode RFC: Consolidate pre/code/inlineCode Mar 26, 2020
@wooorm
Copy link
Member

wooorm commented Apr 23, 2020

@johno So, are you proposing dropping the inlineCode node, and going with mdast + jsx + expressions + imports + exports, only?

@johno
Copy link
Member Author

johno commented May 1, 2020

Yeah, that's the proposal @wooorm, but after thinking about it I'm not sure it's worth the breaking change right now since it isn't really hard to support and has come pretty embedded in MDXProvider usage.

Might be something to put back on the table for v3.

@johno johno closed this as completed May 1, 2020
@johno johno added this to the v2 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 v2 Issues related to v2
Development

No branches or pull requests

3 participants