Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less strict version dependecy for "remark-parse" #1548

Closed
salzig opened this issue May 11, 2021 · 6 comments
Closed

less strict version dependecy for "remark-parse" #1548

salzig opened this issue May 11, 2021 · 6 comments
Labels
👯 no/duplicate Déjà vu 👀 no/external This makes more sense somewhere else

Comments

@salzig
Copy link

salzig commented May 11, 2021

given that remarkjs/remark#710 may succeed, it would be awesome to have a new 1.6 (maybe 1.6.23) release with a less strict (allow patches, or just updated) dependency for "remark-parse". So we can get away from "trim" 0.0.1 cheap.

@salzig salzig added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels May 11, 2021
@salzig
Copy link
Author

salzig commented May 11, 2021

yes, i've seen #1458. But doing a major upgrade is out of scope for me, that's why i ask for an patchlevel release :)

@JounQin
Copy link
Member

JounQin commented May 11, 2021

Or you can just try the following for now.

// package.json
{
  "resolutions": {
    "trim": "^1.0.1"
  }
}

@salzig
Copy link
Author

salzig commented May 11, 2021

@JounQin that works (if you're using yarn, not npm), but it is just a workaround :)

@ChristianMurphy
Copy link
Member

Duplicate of #1531 and #1458, this is resolved in mdx version 2 #1041 and in xdm

@ChristianMurphy ChristianMurphy added 👯 no/duplicate Déjà vu 👀 no/external This makes more sense somewhere else and removed 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels May 11, 2021
@salzig
Copy link
Author

salzig commented May 11, 2021

@ChristianMurphy so you didn't read my comment? Doing a major upgrade is out of scope. Would be that complicated to release a patch version?

@ChristianMurphy
Copy link
Member

ChristianMurphy commented May 11, 2021

I read your comment.
The v2 major version is a non-breaking update for a majority of users.
Also a patch release to MDX wouldn't fix it, as it is a transitive dependency through remark, not a dependency of mdx.
mdx v1 can't use remark-parse 9, as it requires changes to the mdx parser, these changes are part of the v2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👀 no/external This makes more sense somewhere else
Development

No branches or pull requests

3 participants