fix: only add _componentX to _createMdxContent

mdx-js · Aug 15, 2022 · a9d93b2 · a9d93b2
1 parent 55414b4
commit a9d93b2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/packages/mdx/lib/plugin/recma-jsx-rewrite.js b/packages/mdx/lib/plugin/recma-jsx-rewrite.js
@@ -358,23 +358,25 @@ export function recmaJsxRewrite(options = {}) {
               componentsInit = {type: 'Identifier', name: '_components'}
             }
 
-            for (const [id, componentName] of idToInvalidComponentName) {
-              // For JSX IDs that can’t be represented as JavaScript IDs (as in,
-              // those with dashes, such as `custom-element`), generate a
-              // separate variable that is a valid JS ID (such as `_component0`),
-              // and takes it from components:
-              // `const _component0 = _components['custom-element']`
-              declarations.push({
-                type: 'VariableDeclarator',
-                id: {type: 'Identifier', name: componentName},
-                init: {
-                  type: 'MemberExpression',
-                  object: {type: 'Identifier', name: '_components'},
-                  property: {type: 'Literal', value: id},
-                  computed: true,
-                  optional: false
-                }
-              })
+            if (isNamedFunction(scope.node, '_createMdxContent')) {
+              for (const [id, componentName] of idToInvalidComponentName) {
+                // For JSX IDs that can’t be represented as JavaScript IDs (as in,
+                // those with dashes, such as `custom-element`), generate a
+                // separate variable that is a valid JS ID (such as `_component0`),
+                // and takes it from components:
+                // `const _component0 = _components['custom-element']`
+                declarations.push({
+                  type: 'VariableDeclarator',
+                  id: {type: 'Identifier', name: componentName},
+                  init: {
+                    type: 'MemberExpression',
+                    object: {type: 'Identifier', name: '_components'},
+                    property: {type: 'Literal', value: id},
+                    computed: true,
+                    optional: false
+                  }
+                })
+              }
             }
 
             if (componentsPattern) {

diff --git a/packages/mdx/test/compile.js b/packages/mdx/test/compile.js
@@ -864,7 +864,7 @@ test('jsx', async () => {
       '  return <>{<_component0></_component0>}</>;',
       '}',
       'function MDXContent(props = {}) {',
-      '  const _component0 = _components["a-b"], {wrapper: MDXLayout} = props.components || ({});',
+      '  const {wrapper: MDXLayout} = props.components || ({});',
       '  return MDXLayout ? <MDXLayout {...props}><_createMdxContent {...props} /></MDXLayout> : _createMdxContent(props);',
       '}',
       'export default MDXContent;',