Regression of stable/reliable run since v1.12 #339
Comments
codejedi365
added
🐛 type/bug
|
Please try to use You're running |
diff --git a/.eslintrc.js b/.eslintrc.js
index e23d28c..826d5b5 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -5,16 +5,7 @@ module.exports = {
es2017: true,
node: true
},
- extends: [
- // JS, MD, MDX
- "eslint:recommended",
- "airbnb-base",
- "plugin:mdx/recommended",
- "plugin:prettier/recommended"
- ],
- settings: {
- "mdx/code-blocks": true
- },
+ extends: ["eslint:recommended", "airbnb-base", "plugin:prettier/recommended"],
ignorePatterns: [
"**/node_modules",
"dist/**",
@@ -28,6 +19,13 @@ module.exports = {
"import/no-extraneous-dependencies": "off"
},
overrides: [
+ {
+ files: ["*.md", "*.mdx"],
+ extends: ["plugin:mdx/recommended"],
+ settings: {
+ "mdx/code-blocks": true
+ }
+ },
{
files: ["*.json", ".remarkrc"],
plugins: ["json-format"] |
JounQin
added
🙋 no/question
|
|
|
Thank you for the quick reply & fix, that worked significantly. Down to <10 second runtime with the latest version |
|
Reopen if necessary... I spoke too soon. I still have a remark failure Failing CI run with TS codeblocks in README.md If I change them to JS code blocks, then it resolves but then doesn't like the Typescript syntax which can be seen here: |
|
Then it's a bug of
|
|
After debugging, {
"ruleId": null,
"fatal": true,
"severity": 2,
"message":
"Parsing error: \"parserOptions.project\" has been set for @typescript-eslint/parser.\n" +
"The file does not match your project config: README.md/0_0.ts.\n" +
"The file must be included in at least one of the projects provided.",
"line": undefined,
"column": undefined
} |
|
@codejedi365 Adding More details: https://eslint.org/docs/user-guide/configuring/configuration-files#how-do-overrides-work |
|
@JounQin, thank you for continuing to investigate a solution. However,
resolves the undefined error by omitting it to be parsed as Typescript. It then uses the basic JS parser which doesn't throw an exception but rather fails to parse Typescript specific syntax where it is located. Since TS is so closely related to JS, it works on the common syntax. Specifically, the I am pursuing an implementation of a Typescript specific config just for eslint which falls in line with this StackOverflow Post but I haven't gotten it to work yet. I'm not sure how you debugged |
|
|
|
Glad to see this resolution opened since it would of been helpful to see the error from Separately, I looked into these links/recommendations and found a better solution:
There were 2 parts to my solution:
Overall, this solution enabled codeblocks with TS syntax to be parsed correctly (which the default eslint JS parser cannot do) and apply most of all the other Typescript specific rules to the code contained in markdown-code-blocks. My final configuration looks like: diff --git a/.eslintrc.js b/.eslintrc.js
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ +6,22 +7,23 @@ module.exports = {
plugins: ["json-format"]
},
{
files: ["*.ts"],
+ excludedFiles: ["*.m{d,dx}/*.ts"],
parser: "@typescript-eslint/parser",
parserOptions: {
ecmaVersion: 8,
project: "tsconfig.json"
},
plugins: ["@typescript-eslint", "jest", "import"],
extends: [
"eslint:recommended",
"airbnb-typescript/base",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:jest/recommended",
"plugin:jest/style",
"plugin:prettier/recommended"
],
@@ -80,14 +100,46 @@ {
files: ["*.md", "*.mdx"],
extends: ["plugin:mdx/recommended"],
settings: {
"mdx/code-blocks": true
}
},
{
+ // Markdown JS code-blocks (virtual filepath)
+ files: ["**/*.md/*.{js,jsx}"],
+ rules: {
+ // Invalid rules for embedded code-blocks
+ "import/no-unresolved": "off",
+ "no-undef": "off",
+ "no-unused-expressions": "off",
+ "no-unused-vars": "off",
+ "no-unreachable": "off"
+ }
+ },
+ {
+ // Markdown TS code-blocks (virtual filepath)
+ files: ["**/*.md/*.{ts,tsx}"],
+ parser: "@typescript-eslint/parser",
- parserOptions: {
- ecmaVersion: 8,
- project: "tsconfig.eslint.json"
- },
+ plugins: ["@typescript-eslint"],
+ extends: [
+ "eslint:recommended",
+ "airbnb-typescript/base",
+ "plugin:@typescript-eslint/recommended",
+ "plugin:prettier/recommended"
+ ],
+ rules: {
+ // Additional embedded code-block invalid rules
+ "import/no-unresolved": "off",
+ "no-undef": "off",
+ "no-unused-expressions": "off",
+ "no-unused-vars": "off",
+ "no-unreachable": "off"
+ "@typescript-eslint/no-unused-vars": "off",
+ // Typescript rules that require a project tsconfig.json which is not possible
+ "@typescript-eslint/dot-notation": "off",
+ "@typescript-eslint/no-implied-eval": "off",
+ "@typescript-eslint/no-throw-literal": "off",
+ "@typescript-eslint/return-await": "off",
+ // Readmes should be extra specific or generic as desired
+ "@typescript-eslint/no-inferrable-types": "off",
+ "@typescript-eslint/ban-types": "warn"
+ }
}
]
};Proof of resolution: https://github.com/codejedi365/avl-treemap/runs/3448583865?check_suite_focus=true |
|
Yes, you're separating code blocks and normal physical |
Subject of the issue
Semver Minor upgrades have made functionality & performance worse over the last four versions. Yesterday, I went to run the linter after trashing
package-lock.jsonand re-installing the updates, I foundnpm run linthitting a runtime error. I incrementally rolled back the updates and found none of the latest versions are stable or working well.In summary I found:
v1.14 - v1.15: TypeError: Cannot read property of 'indent' of undefinedv1.13.0: Infinite Loop (never)v1.12.0: Terrible Performance but finishes eventually (45sec)v1.11.0: BEST PERFORMANCE (7sec)I isolated the issue to be this plugin via
.eslintrc.jsas I commented out theplugin:mdx/recommendedand everything works if it doesn't pass through this plugin.Your environment
OS: Mac OS v11.5
Packages:
@typescript-eslint/eslint-plugin@^4.29.1@typescript-eslint/parser@^4.29.1eslint@^7.32.0eslint-config-airbnb-base@^14.2.1eslint-config-airbnb-typescript@^12.3.1eslint-config-prettier@^8.3.0eslint-plugin-import@^2.24.0eslint-plugin-jest@^24.4.0eslint-plugin-json-format@^2.0.1eslint-plugin-mdx@~1.11.0eslint-plugin-prettier@^3.4.0eslint-plugin-mdx@~1.11.0eslint-plugin-prettier@^3.4.0prettier@^2.3.2remark-lint-alphabetize-lists@^3.0.0remark-lint-no-dead-urls@^1.1.0remark-preset-lint-consistent@^4.0.0remark-preset-lint-markdown-style-guide@^4.0.0remark-preset-lint-recommended@^5.0.0remark-preset-prettier@^0.5.1ts-loader@^9.2.5typescript@^4.3.5Env:
Node LTS v12&Node LTS v14,[email protected]Steps to reproduce
Expected behaviour
What should happen?
eslintshould search through the entire project directory for the specified file extensions and run the linting rules against the specific file type. It should parse markdown files with the mdx plugin and identify flaws. The other files will be parsed by their code specific parsers. The mdx plugin should also evaluate the code segments within a markdown file and apply code style rules to those blocks as well. This should not take a long time for the amount of files I have. The CI Pipeline results returned in 7sec and even less on my desktop machine inv1.11.0Valid CI pipeline results are available for review at https://github.com/codejedi365/treemap-js/runs/3407176892?check_suite_focus=true.
Actual behaviour
In
v1.14.0&v1.15.0:In
v1.13.0, it never returns >2min.In
v1.12.0: It resolves but it will print out all the issues, including the summary, and then just hang for 30 seconds without doing anything.In
v1.11.0, it runs with the best performance at about 7 seconds for my project. My CI pipeline results are available for review at https://github.com/codejedi365/treemap-js/runs/3407176892?check_suite_focus=true.The text was updated successfully, but these errors were encountered: