Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Official" Solution 3 Seems Awkward for a Beginner #30

Closed
mist83 opened this issue Aug 3, 2015 · 1 comment
Closed

"Official" Solution 3 Seems Awkward for a Beginner #30

mist83 opened this issue Aug 3, 2015 · 1 comment

Comments

@mist83
Copy link

mist83 commented Aug 3, 2015

Just my 2 cents, but

The problem requests a solution in the following order:

  • over 1 million
  • less than 1 million but more than 0.5
  • less than 0.5

The solution answers it in a different order:

  • over 1 million
  • less than 0.5
  • less than 1 million but more than 0.5

Doing it this way is not only different than the flow of the written description of the problem, it also forces you to mix operators (greater than and then less than) instead of a smooth, consistent "greater than 1M / greater than 0.5M / else."

Slightly related (but nitpicky): the way the question is worded, it precludes assigning a "size" property to cities that are exactly 1M or 0.5M in population.

@mist83 mist83 changed the title "Official" Solution 3 seems awkward for a beginner "Official" Solution 3 Seems Awkward for a Beginner Aug 3, 2015
@mdunisch
Copy link
Owner

mdunisch commented Oct 7, 2015

Thank you @mist83 for pointing this out! You are totally right, I changed the solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants