Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables to define which hemisphere to default to #208

Closed
mdtanker opened this issue Jun 5, 2024 · 0 comments · Fixed by #212
Closed

Use environment variables to define which hemisphere to default to #208

mdtanker opened this issue Jun 5, 2024 · 0 comments · Fixed by #212

Comments

@mdtanker
Copy link
Owner

mdtanker commented Jun 5, 2024

In PR #212 we added support for Greenland and the Arctic, with some datasets, and extensions of the plotting functions to include the projection EPSG 3413 for the arctic region. To do this, we needed to add the parameter hemisphere to many functions throughout the code to tell PolarToolkit whether to expect data in EPSG 3031 or 3413, for the south or north hemispheres, respectively. While this works, it is cumbersome, especially since most research focus on either hemisphere, but typically not both.

To fix this we should suggest users set an environment variable in there OS, such as polartoolkit_hemisphere, and all our functions which use hemisphere, will check if this variable exists, and use it if so.

This was linked to pull requests Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant