Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding regional and optimization modules #30

Merged
merged 30 commits into from
Nov 30, 2023
Merged

Adding regional and optimization modules #30

merged 30 commits into from
Nov 30, 2023

Conversation

mdtanker
Copy link
Owner

No description provided.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

used a function from a stack overlow answer which is able to get cpu core numbers for many operating systems since psutil doesn't seem to work for MacOS or Windows.
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (cade158) 39.45% compared to head (d4c9c8f) 42.80%.

Files Patch % Lines
src/invert4geom/optimization.py 45.81% 110 Missing ⚠️
src/invert4geom/regional.py 75.00% 17 Missing ⚠️
src/invert4geom/synthetic.py 0.00% 16 Missing ⚠️
src/invert4geom/utils.py 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   39.45%   42.80%   +3.34%     
==========================================
  Files           6        8       +2     
  Lines         811     1119     +308     
==========================================
+ Hits          320      479     +159     
- Misses        491      640     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.3.0-rc.1.

@mdtanker
Copy link
Owner Author

Some tests are still failing.

  • Windows w/ Python 3.11 fails due to dependency issue with botorch
  • Windows w/ Python 3.10 fails due to file permission issue in test_optuna_parallel
  • Window w/ Python 3.8 fails due to file permission issue in test_optuna_parallel
  • MacOS w/ Python 3.11 fails due to test_optuna_parallel

Not too sure how to fix, it might just be an issue on Github actions and not on a local machine.

@mdtanker mdtanker closed this Nov 30, 2023
@mdtanker mdtanker reopened this Nov 30, 2023
@mdtanker mdtanker merged commit daf3c9c into main Nov 30, 2023
9 of 16 checks passed
@mdtanker mdtanker deleted the dev branch November 30, 2023 13:48
mdtanker added a commit that referenced this pull request Nov 30, 2023
mdtanker added a commit that referenced this pull request Nov 30, 2023
@mdtanker mdtanker restored the dev branch November 30, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants