Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @webref/css from 5.4.4 to 6.0.0 #9621

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 7, 2023

Summary

Problem

We're using @webref/css v5, which is outdated.

Solution

Upgrade to @webref/css v6 and migrate the CSSSyntax macro accordingly.

Note: I intentionally upgraded to 6.0.0, and not to the latest v6 version, to separate the migration from data updates.


How did you test this change?

Ran yarn && yarn dev and verified the macro on the following pages (also tested by the snapshot tests):

dependabot bot and others added 2 commits September 7, 2023 04:37
Bumps [@webref/css](https://github.com/w3c/webref) from 5.4.4 to 6.0.0.
- [Release notes](https://github.com/w3c/webref/releases)
- [Commits](https://github.com/w3c/webref/compare/@webref/[email protected]...@webref/[email protected])

---
updated-dependencies:
- dependency-name: "@webref/css"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions github-actions bot added dependencies Pull requests that update a dependency file macros tracking issues related to kumascript macros labels Sep 7, 2023
@caugner caugner temporarily deployed to xyz September 7, 2023 02:52 — with GitHub Actions Inactive
@caugner caugner requested a review from LeoMcA September 7, 2023 03:00
@caugner caugner marked this pull request as draft September 7, 2023 03:41
@caugner caugner temporarily deployed to xyz September 7, 2023 04:05 — with GitHub Actions Inactive
@caugner caugner marked this pull request as ready for review September 7, 2023 04:15
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a sensible approach to me! tests pass so I'm happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants