Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signup-link): clicking led to 404 #9390

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix(signup-link): clicking led to 404 #9390

merged 1 commit into from
Jul 26, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 26, 2023 •
edited
Loading

Summary

Problem

  • clicking "Sign up for free" button leads to a 404

Solution

  • set target="_self" on link to force it to be a "true" <a> tag
  • we should make this default in future, and "opt-in" to internal links in various plus features, but this is a hotfix for now

@LeoMcA
fix(signup-link): clicking led to 404
2ee44e4 
as it was an InternalLink rather than a true <a>
@LeoMcA LeoMcA requested a review from fiji-flo July 26, 2023 16:00
fiji-flo
fiji-flo approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LeoMcA LeoMcA merged commit 24bdfe2 into main Jul 26, 2023
13 checks passed
@LeoMcA LeoMcA deleted the fix-signup-link branch July 26, 2023 16:07
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoMcA @fiji-flo