Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(signup): replace "Get MDN Plus" with "Sign up for free" #9357

Merged
merged 15 commits into from
Jul 25, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 20, 2023

Summary

Problem

We don't make it very clear that signing up for MDN Plus is actually free (on the Core plan).

Solution

Replace the "Get MDN Plus" button (linking to the MDN Plus offer overview page) with a "Sign up for free" button (linking to the login/signup workflow).

Also extracts the login banner as PlusLoginBanner and improves its responsiveness.


Screenshots

Playground

Before

image

After

image

Updates

Before

image

After

image

AI Help

Before

image

After

image

Responsiveness

Before After
image image
image image
image image

How did you test this change?

Ran yarn && yarn dev (with rumba running) and visited the following URLs without being authenticated:

  1. http://localhost:3000/en-US/play (click on "Share")
  2. http://localhost:3000/en-US/plus/updates
  3. http://localhost:3000/en-US/plus/ai-help/

Also replaces "Upgrade to MDN Plus" with "Log in to MDN Plus".
@caugner caugner requested a review from LeoMcA July 20, 2023 16:51
@github-actions github-actions bot added the plus work around features related to MDN Plus label Jul 20, 2023
@caugner caugner marked this pull request as ready for review July 20, 2023 16:57
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two technical notes, otherwise UX ones which aren't blockers - though I feel quite strongly about them, "log in" should be reserved for clickable things (which log you in), I remember in my days working on Mozilla IAM us finding out users are incredibly prone to confusion in log in/sign up flows, and they need to be as straightforward as possible.

client/src/playground/forms.tsx Outdated Show resolved Hide resolved
client/src/playground/forms.tsx Outdated Show resolved Hide resolved
client/src/plus/ai-help/login-banner.tsx Outdated Show resolved Hide resolved
client/src/plus/updates/login-banner.tsx Outdated Show resolved Hide resolved
client/src/telemetry/constants.ts Outdated Show resolved Hide resolved
@caugner caugner requested a review from LeoMcA July 21, 2023 21:25
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push fixes to the following and merge:

@@ -6,7 +6,7 @@ import { FXA_SIGNIN_URL, KUMA_HOST } from "../../../env";
import "./index.scss";
import { useGleanClick } from "../../../telemetry/glean-context";

export default function SignInLink({
export default function LogInLink({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the className below should be updated to login-link as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 54e720e

const loginUrl = useLoginUrl();

const href = toPlans ? plansUrl : loginUrl;
const label = toPlans ? "Upgrade Now" : "Sign up for free";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The longer length of "Sign up for free" in the header causes weird behaviour just prior to the breakpoint:

Screen Shot 2023-07-25 at 13 16 05

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 051bc8a

Header now uses a smaller gap between elements in large breakpoint:

Screen Shot 2023-07-25 at 17 50 20

Comment on lines 18 to 41
@media screen and (min-width: $screen-md) and (max-width: ($screen-lg - 1)) {
> span {
/* Show text (in two lines) on the left, while "Log in" / "Sign up" are (in one line) on the right. */
display: flex;
flex-direction: column;
}
}

@media screen and (max-width: ($screen-lg - 1)) {
.auth-container {
/* Always keep "Log in" / "Sign up" (in one line) in bottom-right corner. */
align-self: end;
flex-flow: row;
justify-content: flex-end;
margin-bottom: 0;
}
}

@media screen and (max-width: ($screen-md - 1)) {
/* Show text (in one line) above "Log in" / "Sign up" (in one line). */
flex-direction: column;
gap: 0.5rem;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too complex just to make the button wrap nicely on small screens.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 304bcd4

button now wraps like so:

Screen Shot 2023-07-25 at 17 48 49

@LeoMcA LeoMcA merged commit 2abbeba into main Jul 25, 2023
14 checks passed
@LeoMcA LeoMcA deleted the sign-up-for-free branch July 25, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants