-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(signup): replace "Get MDN Plus" with "Sign up for free" #9357
Conversation
Also replaces "Upgrade to MDN Plus" with "Log in to MDN Plus".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two technical notes, otherwise UX ones which aren't blockers - though I feel quite strongly about them, "log in" should be reserved for clickable things (which log you in), I remember in my days working on Mozilla IAM us finding out users are incredibly prone to confusion in log in/sign up flows, and they need to be as straightforward as possible.
Co-authored-by: Leo McArdle <[email protected]>
The Playground banner already had this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll push fixes to the following and merge:
@@ -6,7 +6,7 @@ import { FXA_SIGNIN_URL, KUMA_HOST } from "../../../env"; | |||
import "./index.scss"; | |||
import { useGleanClick } from "../../../telemetry/glean-context"; | |||
|
|||
export default function SignInLink({ | |||
export default function LogInLink({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the className below should be updated to login-link
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 54e720e
const loginUrl = useLoginUrl(); | ||
|
||
const href = toPlans ? plansUrl : loginUrl; | ||
const label = toPlans ? "Upgrade Now" : "Sign up for free"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@media screen and (min-width: $screen-md) and (max-width: ($screen-lg - 1)) { | ||
> span { | ||
/* Show text (in two lines) on the left, while "Log in" / "Sign up" are (in one line) on the right. */ | ||
display: flex; | ||
flex-direction: column; | ||
} | ||
} | ||
|
||
@media screen and (max-width: ($screen-lg - 1)) { | ||
.auth-container { | ||
/* Always keep "Log in" / "Sign up" (in one line) in bottom-right corner. */ | ||
align-self: end; | ||
flex-flow: row; | ||
justify-content: flex-end; | ||
margin-bottom: 0; | ||
} | ||
} | ||
|
||
@media screen and (max-width: ($screen-md - 1)) { | ||
/* Show text (in one line) above "Log in" / "Sign up" (in one line). */ | ||
flex-direction: column; | ||
gap: 0.5rem; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too complex just to make the button wrap nicely on small screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Problem
We don't make it very clear that signing up for MDN Plus is actually free (on the Core plan).
Solution
Replace the "Get MDN Plus" button (linking to the MDN Plus offer overview page) with a "Sign up for free" button (linking to the login/signup workflow).
Also extracts the login banner as
PlusLoginBanner
and improves its responsiveness.Screenshots
Playground
Before
After
Updates
Before
After
AI Help
Before
After
Responsiveness
How did you test this change?
Ran
yarn && yarn dev
(with rumba running) and visited the following URLs without being authenticated: