-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(seo): link technologies in homepage hero #11877
Conversation
Also, don't underline on focus, as focus already has an outline.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
(MP-1550)
Problem
The homepage hero mentions CSS, HTML, and JavaScript, but there is no link to content of this topic.
Solution
Add links to the keywords.
Screenshots
Before
After
How did you test this change?
Ran
yarn dev
, opened http://localhost:3000/en-US/ and clicked each of the new links in the hero section. Also verified that underline on hover still works for the links in the other homepage sections.