fix(macros/jsxref): fix dot handling #11869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we replaces all single dots with a slash.
This resulted in:
{{jsxref("Operators/new%2Etarget", "new.target")}}
An alternative is to change the logic to:
If there is an slash in the 1st parameter don't replace the dots.
This works for all en-US and the issue I found in translated content
where alread broken.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
changed the title
|
@Josh-Cena could you take a look at this? |
|
This is one step in the direction of my great plans of a smart jsxref 😄 I'm not sure anyone has appetite to review all of those changes but this one looks safe to me. |
argl
approved these changes
Sep 29, 2024
argl
added a commit
to mdn/content
that referenced
this pull request
Nov 5, 2024
argl
added a commit
to mdn/content
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we replaces all single dots with a slash. This resulted in:
{{jsxref("Operators/new%2Etarget", "new.target")}}An alternative is to change the logic to:
If there is an slash in the 1st parameter don't replace the dots. This works for all en-US and the issue I found in translated content where alread broken.
Problem
Allow
{{jsxref("Operators/new.target", "new.target")}}Solution
Change the logic and don't replace dot's if there's slashes.
How did you test this change?
Locally