Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macro): Fix two flaws in CSSRef.ejs #11081

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(macro): Fix two flaws in CSSRef.ejs #11081

merged 1 commit into from
May 7, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented May 7, 2024 •
edited
Loading

Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS

Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics

This fixes 1031 flaws! 🎉

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner May 7, 2024 06:27
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label May 7, 2024
estelle
estelle approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you Onkar!

fiji-flo
fiji-flo approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@fiji-flo fiji-flo merged commit 344ec8c into mdn:main May 7, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request May 7, 2024
Merged
@OnkarRuikar OnkarRuikar deleted the patch-2 branch May 7, 2024 08:03
@OnkarRuikar OnkarRuikar mentioned this pull request May 7, 2024
Merged
@estelle estelle mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @estelle @fiji-flo